BenderV
commented
9 years ago Alright. I revisited a bit everything. I can make an example-docs page.
There are however, few things that bugs me. There is not a clear separation between mixin and normal styling. The other things is that bourbon, the sass mixin set that we are based on, is now being separated in two, aka Bourbon & Bitters.
Bourbon is only set of mixin and bitters is default css style for basic element.
About eggshell.
It's not clear the distinction between default and common. There is always some mixin and some css normal class.
- arrow: X (I'm not sure what is the use or how to use it)
- button: ok
- dropdown: great but need an example
- font: ?
- form: is flexible enough?
- icon: awesome but no location/name choice for the set of icons. (and not explanation)
- loading, awesome but we should have set of loading icon ready (maybe done in css?)
- pulse: awesome
- spin: awesome
- tooltip: awesome but we can add corner, multilines and maybe add a slow fade-out
- modal: awesome but need simplification. We also should transform to a mixin, no ?
- overlay as a mixin too.
- notification: awesome but do it as a mixin
- table: default css.
- list: I'm not sure if I get this correctly. It seems like a meny list code: good.
we maybe need to have buttons (flat, rectangular, ect), because they will be depreciated in the next version of bourbon. or we need to add refills too.
nice other thing sass set
My point is that Eggshell is a light layer on top of bourbon. However, we should decide what exactly the end-goal is. Should we have only mixin? or should we try to create a set of component (integrate with react?!) ? Should we try to make all of those components a variable by a style guideline?
But I can simply start by making a simple example-docs page and you can iterate from there.
hunvreus
I see a pull request about examples, but what I see useful is a demo page that demonstrates all the styles. The issue here is that when our designer design a page (e.g. http://wiredcraft.com/lorem/), there's no clear guidance of what's defined and what's free.