search

Wiredcraft / fullpm

Kanban board for GitHub issues
https://wiredcraft.com/products/fullpm
1 stars 3 forks source link

Extension Re-think Proposal #14

Open Jamesford opened 8 years ago

Jamesford commented 8 years ago

Currently the plan for the extension is to add a new tab to github where we inject an <iframe> of the KenHQ site for the correct user/repo.

Since GitHub is served over SSL we cannot have the extension iframe load localhost unless we serve localhost with SSL (which we can probably get working). Or we could wait until the KenHQ website is ready and served over SSL and then develop the extension.

However, I propose we take a different approach. Instead of injecting an <iframe> into the tab we create, I suggest we inject the app (react) directly into the page. To keep it lightweight we could strip out the router/navigation related stuff and only have the code for viewing a single repo's board. We would need to rewrite the existing client-side api calls**, as we would have to make the requests via the extension's background script to get around the http/https mixed content issues.

I'll do some investigation so we can be sure this proposal is viable, but feedback on this idea vs the current idea would be good to hear from the team.

\ Maybe not a rewrite, but we would have to write code for the content-script to background-script communication.

/cc @makara @JuhaS @EcutDavid

JuhaS commented 8 years ago

Lets have the first version with iframe and re-assess after we have people using it.