search

Wiredcraft / fullpm

Kanban board for GitHub issues
https://wiredcraft.com/products/fullpm
1 stars 3 forks source link

Bug: Handle case where user is not logged in #17

Open JuhaS opened 8 years ago

JuhaS commented 8 years ago

We should gracefully handle case where user is not logged in but asks for a private board. We should show "Please login" or "Repository not found" depending on the case.

EcutDavid commented 8 years ago

@makara can I get the information whether a repo is private?

JuhaS commented 8 years ago

For now lets just always show "Repository not found" if the board doesn't load from backend.

EcutDavid commented 8 years ago

Related code pushed, forcing user login first.

EcutDavid commented 8 years ago

Investigating on "Repository not found"

EcutDavid commented 8 years ago

"Repository not found" implemented.

Now, we are forcing user log in first, so closing.

hunvreus commented 8 years ago

I don't think we've finished that user story. Right now, when you're not logged in, it still display the box. But I think we have two different things:

  1. The log in box that should be displayed by default when you visit http://fullpm.com
  2. The message informing you that you should log in when trying to access a board.

We haven't implemented 2 (and it also somehow shows up for a few milliseconds when you're logged in and you're loading the board).

In case 2, the extension also should open automatically a second page or show the extension drop down for the user to log in. Upon logging in, we may want to auto-reload the board, or let the user click on a button to reload the board.

@EcutDavid @Jamesford not sure I'm making myself clear there. Maybe I should write a user story.