Closed hunvreus closed 7 years ago
Change config files and use environment variables instead of hard coding client server / secret. So I can encrypt the sensitive data and store it in ansible vault and then set those environment variables when issue an deployment.
Done. @sunsongxp Let me know if you need more change.
Done.
Right now, the API contains the configuration for
clienID
andclientSecret
from GitHub. It's obviously not OK to share this as OSS moving forward. How do we remove it from our codebase while preserving the ability to run/test stuff locally?/cc @makara @zbal @sunsongxp