search

Wiredcraft / fullpm

Kanban board for GitHub issues
https://wiredcraft.com/products/fullpm
1 stars 3 forks source link

Remove all sensitive data from codebase #54

Closed hunvreus closed 7 years ago

hunvreus commented 8 years ago

Right now, the API contains the configuration for clienID and clientSecret from GitHub. It's obviously not OK to share this as OSS moving forward. How do we remove it from our codebase while preserving the ability to run/test stuff locally?

/cc @makara @zbal @sunsongxp

sunsongxp commented 8 years ago

Change config files and use environment variables instead of hard coding client server / secret. So I can encrypt the sensitive data and store it in ansible vault and then set those environment variables when issue an deployment.

makara commented 7 years ago

Done. @sunsongxp Let me know if you need more change.

sunsongxp commented 7 years ago

Done.