search

Wiredcraft / test-backend

39 stars 76 forks source link

Test Backend - Alexis Lutun First version #11

Closed Alutun closed 7 years ago

Alutun commented 7 years ago

Please refer to README for all the information. If you have any questions, remarks or suggestions, feel free to let me know

I'm not sure who to tag so I tag @makara since we meet each other.

xavierchow commented 7 years ago

@Alutun I'm not sure how you handle the code style, but running npm run lint shows lots of error from my local environment.

Alutun commented 7 years ago

@xavierchow Indeed you are right I forgot to run lint to check my syntax, my bad... I'm in fact the first one usually make sure coding syntax are respected while working with other people. Do you want me to push a new commit fixing the syntax issue ?

xavierchow commented 7 years ago

@Alutun Yes, please, FYI you can use eslint -fix to automatically fix most of issues, also make sure you are comfortable with OTBS and indent white space, different from C language it's kind of de facto style in node.js world.

Alutun commented 7 years ago

@xavierchow Thanks for the tips, you totally spot my C language coding style. I got no more error when running npm run lint, using the loopback set of rules, let me know if it's ok on your local environment as well.

makara commented 7 years ago

Thanks. That should be enough for us to take a decision. Closing.