search

Wiredcraft / test-backend

39 stars 76 forks source link

Dev #58

Closed haluyhl closed 3 years ago

haluyhl commented 3 years ago

Init PR with basic functionalities: general CRUD, follower API, tests will continue to push docs, comments, and possibly some fixes(pm2 broken atm)

MiffyLiye commented 3 years ago

Hi, I'm Tao from Wiredcraft, I will review the code and ask some questions.

MiffyLiye commented 3 years ago

I found the web api always return status code 200 with error code in response body, which is not typical REST style, can you list the points that you think is essential for RESTful API design

haluyhl commented 3 years ago

I found the web api always return status code 200 with error code in response body, which is not typical REST style, can you list the points that you think is essential for RESTful API design

imo nowadays many so called restful apis are not really single-resource oriented. I think the essential part is to have the agreement across the team for an agreed standards of the design regard both business needs and dev needs. just my option tho, it might be me lacking of pro experiences.

xavierchow commented 3 years ago

Thanks @haluyhl @MiffyLiye , that's pretty much enough for our evaluation, I'm closing the PR. We will get back to you soon @haluyhl