search

Wiredcraft / test-backend

39 stars 76 forks source link

my homework #88

Closed dongsw95 closed 2 years ago

xavierchow commented 2 years ago

@dongsw95 thanks for your PR, I noticed that you organized your API test with postman collection which is fine. However it only covers the public APIs, could you try to add some test codes with jest or mocha, I think either of them is the de-factor test framework for the node.js project in the industry.

dongsw95 commented 2 years ago

@dongsw95 thanks for your PR, I noticed that you organized your API test with postman collection which is fine. However it only covers the public APIs, could you try to add some test codes with jest or mocha, I think either of them is the de-factor test framework for the node.js project in the industry.

Sure. As i said in README.md, add test file is in TODO list, i'll add some test cases tonignt.

xavierchow commented 2 years ago

thank you, this should be good enough for our evaluation. closing now.