search

Wiredcraft / test-backend

39 stars 76 forks source link

done #90

Closed MalavitaC closed 2 years ago

MalavitaC commented 2 years ago

by 蔡忞豪

MiffyLiye commented 2 years ago

Hello, I'm Tao from Wiredcraft, I'm going to review the code and ask some questions.

  1. In typical RESTful API design, what should query API respond when user doesn't exist?
  2. dob field is not saved in create API, do you have API document about how to save dob field in user model?
  3. the unit test doesn't cover CRUD of users, what do you think should be covered in unit test, and how can different style of unit test help our development?
xavierchow commented 2 years ago

@MalavitaC any updates? ^

MalavitaC commented 2 years ago

I worked overtime last weekend, so I didn't update the code.

xavierchow commented 2 years ago

thank you all, closing this PR.

MalavitaC commented 2 years ago

Okay, I was just about to commit code.