search

WirefishInc / wirefish

A blazingly fast multiplatform packet sniffer built with Tauri!
MIT License
276 stars 17 forks source link

DHCP? #32

Open leshow opened 1 year ago

leshow commented 1 year ago

I stumbled across this project, very cool. I wrote a DHCP parser called https://github.com/bluecatengineering/dhcproto and would be interested in adding first-class support for the DHCP protocol to your project. If I work on that, would you be interested in merging?

stefanodevenuto commented 1 year ago

Hi Evan, sorry for the late reply. I've looked at the DHCP parser you developed and it seems really good! Therefore, yes, that would be a useful add to the project.

Are you planning to work "just" on the Rust side or also adding support for DHCP on the "frontend"? Just to know, since right now we are working on re-designing the interface

leshow commented 1 year ago

Whatever you like. I have done a lot of frontend work in the past with react and typescript so I'm pretty at home on that side, if you want me to leave it alone while it gets redesigned that's fine also.

stefanodevenuto commented 1 year ago

Brilliant! If you want, I suggest you to implement the Rust side and then the frontend based on what you already see. In the end, the code you'll write in Typescript will be all reused also in the new interface (not the aesthetics of course)

You can open a PR whenever you want!