search

Wireless-Innovation-Forum / Citizens-Broadband-Radio-Service-Device

Apache License 2.0
32 stars 19 forks source link

WINNF.FT.C.HBT.11 Grant Renew test case will continue forever in case all Heartbeats with AUTHORIZED include GrantRenew=True #128

Open idanrazisr opened 6 years ago

idanrazisr commented 6 years ago

Executing with SAS Harness v1.0.0.2 the test case WINNF.FT.C.HBT.11 for Grant Renew, if the "grantRenew=true" from the very first Heartbeat Request with "AUTHORIZED" state, and also in all the following Heartbeat Requests, then the SAS Harness continues this test forever always giving in Heartbeat Response a new grantExpireTime with a newer date in the future. See log below.

This test is finishing properly only if the "grantRenew=true" appears once during the test in only one of the Heartbeat Request messages (not in the first Heartbeat Request). The situation below occurs when CBSD/DP UUT have their internal Grant Renew timer configured to be 1% of the GrantExpiryTime. So the grantRenew is included in the ALL the Heartbeat Requests with AUTHORIZED state. If a CBSD/DP UUT have their internal timer configured to 50% of the GrantExpiryTime then test WINNF.FT.C.HBT.11 will be executed successfully.

I am NOT asking for a fix to this issue, just to note it.

2018-06-06T11:14:30.226Z - INFO - heartbeat request from CBRS : { "heartbeatRequest": [ { "cbsdId": "airspancbrs1Mock-SASDA5A17CD1214", "grantId": "414394837", "grantRenew": false, "operationState": "GRANTED" } ] } 2018-06-06T11:14:30.243Z - INFO - engine sent successfully, the response to CBRS : { "heartbeatResponse": [ { "cbsdId": "airspancbrs1Mock-SASDA5A17CD1214", "grantId": "414394837", "response": { "responseCode": 0 }, "transmitExpireTime": "2018-06-06T11:17:50Z" } ] } 2018-06-06T11:15:00.325Z - INFO - heartbeat request from CBRS : { "heartbeatRequest": [ { "cbsdId": "airspancbrs1Mock-SASDA5A17CD1214", "grantId": "414394837", "grantRenew": true, "operationState": "AUTHORIZED" } ] } 2018-06-06T11:15:00.325Z - INFO - Time interval between two heartbeat request messages is: 30.099, limit is: 65.0 2018-06-06T11:15:00.342Z - INFO - grantRenew received in HBT request message 2018-06-06T11:15:00.342Z - INFO - engine sent successfully, the response to CBRS : { "heartbeatResponse": [ { "cbsdId": "airspancbrs1Mock-SASDA5A17CD1214", "grantExpireTime": "2018-06-06T11:21:00Z", "grantId": "414394837", "response": { "responseCode": 0 }, "transmitExpireTime": "2018-06-06T11:18:20Z" } ] } 2018-06-06T11:15:30.427Z - INFO - heartbeat request from CBRS : { "heartbeatRequest": [ { "cbsdId": "airspancbrs1Mock-SASDA5A17CD1214", "grantId": "414394837", "grantRenew": true, "operationState": "AUTHORIZED" } ] } 2018-06-06T11:15:30.427Z - INFO - Time interval between two heartbeat request messages is: 30.102, limit is: 65.0 2018-06-06T11:15:30.444Z - INFO - grantRenew received in HBT request message 2018-06-06T11:15:30.444Z - INFO - engine sent successfully, the response to CBRS : { "heartbeatResponse": [ { "cbsdId": "airspancbrs1Mock-SASDA5A17CD1214", "grantExpireTime": "2018-06-06T11:21:30Z", "grantId": "414394837", "response": { "responseCode": 0 }, "transmitExpireTime": "2018-06-06T11:18:50Z" } ] }

cwilliams-ericsson commented 6 years ago

Agree that this test case, as implemented in Test Harness, does not properly handle all the possible cases (i.e. grantRenew in first heartbeat message, grantRenew in all heartbeat messages, etc.). To handle these cases requires changes to Test Harness code (not just .csv or .json files for test case).

Since this test is listed in WINNF-TS-0122-V1.0.0 as OPTIONAL for certification, this is a lower-priority issue.

awaizkhan commented 6 years ago

Will be handled by CBRS-A 3rd part company.