Wireless-Innovation-Forum / Citizens-Broadband-Radio-Service-Device

Apache License 2.0
31 stars 19 forks source link

Ericsson submission nov03 #59

Closed cwilliams-ericsson closed 6 years ago

cwilliams-ericsson commented 6 years ago

New Test Harness functionality drop

cwilliams-ericsson commented 6 years ago

Any consensus yet that this branch can be approved?

awaizkhan commented 6 years ago

Hi Chris, We don’t see any major hurdles approving this. Not sure about Idan’s testing. I’m ok to approve it.

BR, Awaiz

From: cwilliams-ericsson notifications@github.com Reply-To: Wireless-Innovation-Forum/Citizens-Broadband-Radio-Service-Device reply@reply.github.com Date: Monday, November 20, 2017 at 6:43 AM To: Wireless-Innovation-Forum/Citizens-Broadband-Radio-Service-Device Citizens-Broadband-Radio-Service-Device@noreply.github.com Cc: awaizkhan awaiz.khan@ruckuswireless.com, Review requested review_requested@noreply.github.com Subject: Re: [Wireless-Innovation-Forum/Citizens-Broadband-Radio-Service-Device] Ericsson submission nov03 (#59) Resent-From: awaiz.khan@ruckuswireless.com Resent-Date: Monday, November 20, 2017 at 6:43 AM

Any consensus yet that this branch can be approved?

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Wireless-2DInnovation-2DForum_Citizens-2DBroadband-2DRadio-2DService-2DDevice_pull_59-23issuecomment-2D345715672&d=DwMFaQ&c=IL_XqQWOjubgfqINi2jTzg&r=4ogWFyxijxU_p88gjTkqkthlHjK9pAK7QZ8EZYn3ya4&m=Rec_ne4Qmcj6PPcd80hqwSonNW_6G-5I17Z6jQi_EU8&s=iWkimmp83j0KghnCOYa-F9pGlAoZtfTNWxPu7c0Ztiw&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AbdJSQn2-2DUGt52LcE8si6M7hsTUhj44Oks5s4ZAFgaJpZM4QaE0F&d=DwMFaQ&c=IL_XqQWOjubgfqINi2jTzg&r=4ogWFyxijxU_p88gjTkqkthlHjK9pAK7QZ8EZYn3ya4&m=Rec_ne4Qmcj6PPcd80hqwSonNW_6G-5I17Z6jQi_EU8&s=eRpsoQ7ySzOa43TxZfANZQdf0oN9tROpJRgHUc3NkZA&e=.

cwilliams-ericsson commented 6 years ago

I recommend approving ASAP. After all, we are not going back!

Many bugs addressed. Further issues can be included in a new pull-request.