search

WirelessAlien / MovieDB

ShowCase is a fully open-source android application for exploring and organizing your personal collection of films and television series.
GNU General Public License v3.0
130 stars 5 forks source link

[BUG] Can't log into app with TheMovieDB account #2

Closed gabriel-eladi closed 5 months ago

gabriel-eladi commented 5 months ago

Describe the bug When attempting to login with my TheMovieDB account, after clicking "Approve" when prompted, I get redirected to the app but am not logged in.

To Reproduce Steps to reproduce the behavior:

  1. Open app
  2. Click User>Login
  3. Get redirected to TheMovieDB website login page (if not already logged in) and log in
  4. Get prompted to approve Movie DB app and click on approve
  5. Get redirected to Movie DB app, but still not logged in

Expected behavior Get logged into Movie DB app and be able to use online features in app.

Smartphone (please complete the following information):

Additional context Been looking for an android app that would let me log into TheMovieDB and easily sync lists, favorites etc. So glad that someone is actually working on one. Thank you! The app looks great so far!

WirelessAlien commented 5 months ago

I failed to reproduce the issue. I tried to login with different account/device, it works. Did you see the toast - Login Successful, if you did not see that what was the toast that was shown ?. If you saw "Login Successful", then it is logged in, you need to open the login menu again to see the confirmation or you can open any movie details - the buttons (watchlist, list, favourite, rate) will be enabled. 2024-05-17 08-48-29 High Res Screenshot

gabriel-eladi commented 5 months ago

I did not get any toast. Here is a video showing my process: https://youtube.com/shorts/zJi6t-56OSg?si=R6D4PyQbGIhJdN6B.

I forgot to mention, but I am using the latest F-Droid version of the app (v0.5).

WirelessAlien commented 5 months ago

I did not get any toast. Here is a video showing my process: https://youtube.com/shorts/zJi6t-56OSg?si=R6D4PyQbGIhJdN6B.

I forgot to mention, but I am using the latest F-Droid version of the app (v0.5).

I think this is an issue with Firefox custom tab, you need click on "Open in Firefox", then you can login & approve in Firefox browser. The callback does not work within custom tab of Firefox. If it works, let me know. Screenshot_2024-05-17-14-53-10-874_org mozilla firefox

gabriel-eladi commented 5 months ago

That worked, thank you! Still, I would consider this as a bug and something that should be fixed. Maybe make the link open externally, in the default browser, instead of in app by default?