WiringPi / WiringPi-Node

Node.js bindings to wiringPi
334 stars 94 forks source link

Update to libWiringPi v2 #3

Closed nekuz0r closed 10 years ago

nekuz0r commented 10 years ago
nekuz0r commented 10 years ago

This update breaks some user code due to the reorganisation of the wiringPi constants. Maybe will you prefer i put back the previous definitions in exports.js for backward compatibilty ?

Impacted constants are:

modes: {
    INPUT: INPUT,
    OUTPUT: OUTPUT,
    PWM_OUTPUT: PWM_OUTPUT
  },
  pull: {
      OFF: 0,
      DOWN: 1,
      UP: 2
  },
nekuz0r commented 10 years ago

I added backward compatibility constants, so it will not breaks user code :)

spikeheap commented 10 years ago

Great work @nekuz0r. I'd almost given up on wiringPi2 support in node and set about updating this library, but you've done the work for me :). I'm not a maintainer, but this looks good to me.

nekuz0r commented 10 years ago

@spikeheap Thank you, i hope @eugeneware will accept the pull request soon. In the mean time, you can install the updated version with npm (npm install git+https://github.com/nekuz0r/wiring-pi.git) If @eugeneware no longer has time to maintain this package, i would be glad to be a maintainer of it.

spikeheap commented 10 years ago

Thanks @nekuz0r, I'll give it a go while we're waiting for the pull request and see how it goes.

eugeneware commented 10 years ago

Sorry guys - have been on vacation for a few weeks (yes it's nice here in Thailand :-)

This is excellent work. I'm releasing it as 1.0.0 just in case there are any incompatibilities that show up.