search

WiringPi / WiringPi-Node

Node.js bindings to wiringPi
334 stars 94 forks source link

Fixing #45 pinModeAlt mode is checked in wrong ints #46

Closed NoHomey closed 7 years ago

NoHomey commented 7 years ago

pinModeAlt mode should be in (FSEL_INPT, FSEL_OUTP, FSEL_ALT0, FSEL_ALT1, FSEL_ALT2, FSEL_ALT3, FSEL_ALT4, FSEL_ALT5) not in (WPI_MODE_PINS, WPI_MODE_PHYS, WPI_MODE_GPIO).

NoHomey commented 7 years ago

Also found that #24 has been closed with defining and exporting FSEL_INPT, FSEL_OUTP, FSEL_ALT0, FSEL_ALT1, FSEL_ALT2, FSEL_ALT3, FSEL_ALT4, FSEL_ALT5 in a186b9ce0135ca0daefb1ed91f84718b19e34593 but pinModeAlt implementation has not changed in that commit.

NoHomey commented 7 years ago

@nekuz0r could you review this pull request?