search

WiringPi / WiringPi-Node

Node.js bindings to wiringPi
333 stars 94 forks source link

Merging kohei0302/WiringPi-Node #82

Open NoHomey opened 6 years ago

NoHomey commented 6 years ago

Merging changes from @kohei0302.

kohei0302 commented 6 years ago

Hi

It’is not important that this pull request. We should discuss below pull request.

https://github.com/nekuz0r/wiringpi/pull/5

nekuz0r commented 6 years ago

@kohei0302 I reviewed the other pull request, once merged, please update this one to point back to the original repository, and address the requested changes. Also, make sure to squash your commits.

kohei0302 commented 6 years ago

@nekuz0r This version is "2.2.0". What is the next version?

nekuz0r commented 6 years ago

If we want to keep semver 3.0.0

kohei0302 commented 6 years ago

I fixed document and changed the URL of clone.

git clone https://github.com/nekuz0r/wiringpi.git -b v2.44 --depth 1

Please merge and make tag properly. I suggest tag version to be v2.44.

nekuz0r commented 6 years ago

@kohei0302 still waiting for comment on nekuz0r/wiringpi#5