WisconsinAIVision / yolact_edge

The first competitive instance segmentation approach that runs on small edge devices at real-time speeds.
MIT License
1.26k stars 272 forks source link

Bug in augmentation configuration #220

Open domef opened 1 year ago

domef commented 1 year ago

In SSDAugmentation and SSDAugmentationVideo there is an error in the enabling of the rotation augmentation. The line enable_if(cfg.augment_random_flip, RandomRot90()) should be converted in enable_if(cfg.augment_random_rot90, RandomRot90()) in both classes.

https://github.com/haotian-liu/yolact_edge/blob/3f423ede1aeac73dbf86dadfe85af9e288f7f99b/yolact_edge/utils/augmentations.py#L908

https://github.com/haotian-liu/yolact_edge/blob/3f423ede1aeac73dbf86dadfe85af9e288f7f99b/yolact_edge/utils/augmentations.py#L932

domef commented 1 year ago

I fixed the bug and created a pull request: https://github.com/haotian-liu/yolact_edge/pull/221