search

WisconsinRobotics / WRover_Software

The software system for the 2024 Wisconsin Robotics URC rover.
https://wisconsinrobotics.github.io/WRover_Software/
MIT License
6 stars 1 forks source link

Science system #23

Closed dzhao001 closed 2 years ago

dzhao001 commented 2 years ago

Implementation of logic and control ros layer for science system.

Tzanccc commented 2 years ago

There's a few "magic numbers" that should be replaced with constexpr as per linting rules (as well as other minor issues). You can also work on de-linting by installing the clangd and Clang-Tidy plugins in VScode, sudo apt-get install clang-tidy on your computer, and add this to your settings:

"clang-tidy.checks": [
        "bugprone-*",
        "performance-*",
        "readability-*",
        "modernize-*",
        "hicpp-*",
        "cppcoreguidelines-*",
        "clang-analyzer-*",
        "-readability-braces-around-statements",
        "-hicpp-braces-around-statements",
        "-cppcoreguidelines-non-private-member-variables-in-classes"
    ]
bennowotny commented 2 years ago

With respect to the linting question, don't make changes or include extra linting files in this PR; this will be handled in #25.