Closed ak4t0sh closed 5 years ago
Your constants do not use franskenstyle prefix but just EDWISER_ do not you risk collisions with your others plugins?
I'll make sure that this constant will not collide with other plugins. In fist update, I'll change this constant to plugin specific franskenstyle prefix constant.
As described in https://docs.moodle.org/dev/Plugin_files#lib.php :
So your functions should be moved to locallib.php
Moreover to prevent namespace collision you should always use frankenstyle style for your constants and function's name (https://docs.moodle.org/dev/Coding_style#Functions_and_Methods, https://docs.moodle.org/dev/Coding_style#Constants)