Missing bit of description for PassiveSkillBattleStartActivationEffect

[Sylvie]

See Reno

• [x] 236209 Orgueil des TURKs : Réno
• [x] 236210 Accordons-leur un peu de temps

Todo

• [x] Wrong condition for "reraise"
• [x] Missing unit test for case 56?
• [x] What about "BS switch" mentioned on wiki?

  We drop it, it's too complex to determine when to add it to the description

• [x] Check double "Effet activé en début de combat: " on 236210

[Sylvie]

PassiveSkillBattleStartActivationEffect

35

    "910909": {
        "name": "Mortar Beacon",
...
        "effects": [
            ["Gain Mortar Beacon (91007) at the start of a battle or when revived"]
        ],
        "effects_raw": [[2, 1, 35, [91007]]],
...
    },

L'effet 35 a toujours 1 paramètre et son SkillEffect a l'air correct 🆗

56

    "235217": {
        "name": "Blessing of the Black Crystal",
...
        "effects": [
            ["Increase MAG and MP by 30%"],
            ["Increase magic damage against Dragons by 150%"],
            ["Use Aura of Darkness (512090) at the start of a battle or when revived"]
        ],
        "effects_raw": [[0, 3, 1, [0,  0,  30,  0,  0,  30,  0]], [0, 3, 11, [7,  0,  150]], [0, 3, 56, [512090]]],
...
    },

L'effect 56 a généralement 1 paramètre, et il fonctionne aussi après résurrection.

Il y a 1 cas avec 3 paramètres

    "911746": {
        "name": "Trial and Error",
...
        "effects": [
            ["Increase MAG by 50% and MP by 10%"],
            ["Increase equipment MAG by 60% when armed with a single one-handed weapon and no shield"],
            ["Use Trial and Error (911835) at the start of a battle or when revived"]
        ],
        "effects_raw": [[0, 3, 1, [0,  0,  50,  0,  0,  10,  0]], [0, 3, 70, [60,  0,  0]], [0, 3, 56, [911835,  0,  0]]],
...
    },

mais ils n'ont pas l'air de servir à quoi que ce soit.

103

    "241234": {
        "name": "Warring Spirit",
...
        "effects": [
            ["Unknown passive effect type '103': [514555,0,1]"]
        ],
        "effects_raw": [[0, 3, 103, [514555,  0,  1]]],
...
    },

Wiki: Auto-cast Warring Spirit at the start of a battle

Il y a quelques cas avec parameter[2] == 0, mais le wiki donne le même résultat.

    "106010": {
        "name": "Authority of the Courageous",
...
        "effects": [
            ["Unknown passive effect type '103': [514531,0,0]"]
        ],
        "effects_raw": [[0, 3, 103, [514531,  0,  0]]],
...
    },

Wiki: Auto-cast Authority of the Courageous at the start of a battle

Résultats des courses

Seul l'effet 103 ne fonctionne pas après résurrection.