Closed swiftarrow closed 10 years ago
Harish, I don't think you can add your name as author in the code unless / until you have contributed significant changes to the code. Changing this license header is a great help, but it doesn't constitute authorship of the code.
I'm sure you understand. I unfortunately pre-maturely merged your pull request, so I have to ask you to do another pull request where you fix this issue.
Also, separating the authors names by a comma would be good.
Thanks!
Harish, I've reverted your commits, can you separate the requirements commit into it's own pull request so we can get that in, and then fix the license header later? Thanks!
I'll get it done , thanks :)
R.Harish Navnit The Enigma http://harishnavnit.wordpress.com
On Thu, Oct 31, 2013 at 5:09 AM, Linkesh Diwan notifications@github.comwrote:
Harish, I've reverted your commits, can you separate the requirements commit into it's own pull request so we can get that in, and then fix the license header later? Thanks!
— Reply to this email directly or view it on GitHubhttps://github.com/WiseEarthTechnology/CrisisCommunicator/issues/3#issuecomment-27449679 .
I lost track, this has been fixed properly now, right?
The license header has been removed from the files. As per my comment on the original pull request, I would have liked to see variables to track metadata in the files so that its easier to generate documentation. However, its not that important, and can wait till a later day when the app reaches a stable state.
Please remove the header to the files which contains the entire license text, and insert in it's place, the following, simple header: