search

WiseLibs / better-sqlite3

The fastest and simplest library for SQLite3 in Node.js.
MIT License
5.44k stars 395 forks source link

[Idea] Improve prebuilt binary distribution + install script #1070

Closed 0xOlias closed 11 months ago

0xOlias commented 1 year ago

I'm the author of a framework that depends on better-sqlite3 and I'd like to share some feedback that better-sqlite3 installation issues are often the first problem/bug that my users face. There's also a steady stream of installation-related issues opened on this repo.

It would save a lot of new user headache if better-sqlite3 installation was as reliable as esbuild. The esbuild custom install script has (afaict) always successfully found a prebuilt binary on every device I've tried.

Consider this a naive suggestion - I've never worked on a package that has direct native dependencies, so perhaps there is some hidden complexity I'm unaware of.

Frustrations aside, thanks for creating this excellent package! ❤️

Prinzhorn commented 1 year ago

This was being discussed in https://github.com/WiseLibs/better-sqlite3/issues/655 https://github.com/WiseLibs/better-sqlite3/issues/655#issuecomment-1017922157

It's worth pointing out that esbuild is way more trivial, as it's just a binary per platform and arch. better-sqlite3 needs a prebuild for every Node.js/Electron version as well.