search

WiseLibs / better-sqlite3

The fastest and simplest library for SQLite3 in Node.js.
MIT License
5.26k stars 391 forks source link

Not able to use SQLITE_DQS 3 #1078

Closed hbole closed 9 months ago

hbole commented 9 months ago

I have been using better-sqlite3 v8.6.0, I wanted to use SQLITE_DQS value as 3. I follwed the custom compilation method ny downloading the sql-amalgamation and adding it to my project.

I defined SQLITE_DQS as 3 in sqlite3.c like #define SQLITE_DQS 3

Then I used preinstall script to install better-sqlite package "preinstall": "npm install better-sqlite3@^8.6.0 --build-from-source --sqlite3=\"$(pwd)/sqlite-amalgamation\""

But still I can see the value of SQLITE_DQS=0 in /node_modules/better-sqlite3/deps/defines.gypi

I am not able to understand what is the mistake I am doing

Prinzhorn commented 9 months ago

But still I can see the value of SQLITE_DQS=0 in /node_modules/better-sqlite3/deps/defines.gypi

Because that file is shipped with better-sqlite3, there is no reason for it to magically change because you've added a #define to a file in a unrelated folder.

The real question is if SQLITE_DQS works or not? If it does work according to the rules of SQLITE_DQS=3 then your custom amalgamation worked and there is no issue, right?

Since you've omitted --no-save from the docs you're possibly overwriting your custom build, which is made in preinstall. better-sqlite3 should not be in your dependencies, as described in the docs.