Support builds for Electron v29

WiseLibs / better-sqlite3

The fastest and simplest library for SQLite3 in Node.js.

MIT License

5.23k stars 390 forks source link

Support builds for Electron v29 #1151

Closed neoxpert closed 3 months ago

neoxpert commented 4 months ago

This branch adds some adjustments in order to enable builds for Electron v29. The signature of SetAccessor has been adjusted to be the same as before for all versions below 29. For 29 and up the new function signature will be used.

mceachen commented 4 months ago

Thanks for the PR, @neoxpert !

@JoshuaWise can you take a look at this please?

(I don't have merge permissions for this PR)

veemex commented 4 months ago

First of all good job guys! When do you think this can be merged ? I am currently using the branch from @neoxpert , it seems it works for me.

ReconVirus commented 3 months ago

Holy shit this works as ive been having trouble with it for weeks. Hella mad props to @neoxpert for the branch. A simple install npm install neoxpert/better-sqlite3#fix_electron29_build electron-rebuild fucking works no problem now, things just fucking works now thank you so much

@JoshuaWise this is it!

JoshuaWise commented 3 months ago

Sorry for the delay on this one. Thanks for the contribution!