Closed roger-wernersson closed 2 months ago
The type module @types/better-sqlite3 should be compatible with the latest version of better-sqlite3. There haven't been that many changes within the JavaScript API and the module looks like it's on the latest signatures.
@roger-wernersson the external API hasn't changed in many major versions. I've bumped the major version mostly when we drop older versions of Node.js, not because there's a non-backward-compatible API change.
I just reviewed the types and didn't see anything egregiously off. The latest should have the package.json version updated to 9.
I can confirm that it still works
Thanks for the info. You've been very helpful
On Fri, Apr 26, 2024, 06:49 Matthew McEachen @.***> wrote:
@roger-wernersson https://github.com/roger-wernersson the external API hasn't changed in many major versions. I've bumped the major version mostly when we drop older versions of Node.js, not because there's a non-backward-compatible API change.
I just reviewed the types and didn't see anything egregiously off. The latest https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/better-sqlite3 should have the package.json version updated to 9.
— Reply to this email directly, view it on GitHub https://github.com/WiseLibs/better-sqlite3/issues/1174#issuecomment-2078623770, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAYFPGFEAYE2MTPYET72ZA3Y7HMGFAVCNFSM6AAAAABGEHSVHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZYGYZDGNZXGA . You are receiving this because you were mentioned.Message ID: @.***>
What do I do now?
prebuild-install warn install No prebuilt binaries found (target=21.7.3 runtime=node arch=x64 libc= platform=linux) ... ...later ... .../node_modules/better-sqlite3 install: ./src/util/macros.lzz: In function 'void SetPrototypeGetter(v8::Isolate, v8::Local, v8::Local, const char , v8::AccessorGetterCallback)':
.../node_modules/better-sqlite3 install: ./src/util/macros.lzz:157:21: error: 'v8::AccessorSignature' has not been declared
.../node_modules/better-sqlite3 install: ./src/util/binder.lzz: In static member function 'static bool Binder::IsPlainObject(v8::Isolate*, v8::Local)':
.../node_modules/better-sqlite3 install: ./src/util/binder.lzz:37:51: error: 'class v8::Object' has no member named 'CreationContext'; did you mean 'GetCreationContext'?
I'm happy using a pre-built binary. How do I do that?
I'm reluctant to lift the version since I use TypeScript and I only find TypeScript support for version 7.