search

WiseLibs / better-sqlite3

The fastest and simplest library for SQLite3 in Node.js.
MIT License
5.44k stars 394 forks source link

Fix python setuptools on macOS #1181

Closed mceachen closed 5 months ago

mceachen commented 5 months ago

@JoshuaWise this should fix the current build failure on master.

Fixes https://github.com/WiseLibs/better-sqlite3/actions/runs/8853339888/job/24313966887

  1. the if clauses didn't capture macos-latest and macos-14 properly
  2. let's use brew install python-setuptools instead of --break-system-packages.

NOTE: it'd be ideal if we could extract this as a setup task to eliminate the code duplication here, but I didn't want to make the diff bigger. Holler if you'd prefer that.