WiseLibs / better-sqlite3

The fastest and simplest library for SQLite3 in Node.js.
MIT License
5.44k stars 394 forks source link

Support builds for Electron v31 #1200

Closed neoxpert closed 3 months ago

neoxpert commented 3 months ago

Replaced deprecated v8::CopyablePersistentTraits with v8::Global to enabled builds for Electron v31.

JoshuaWise commented 3 months ago

v8::Global is not copyable; it has move semantics. This change should be fine, as we don't use the copy semantics anymore anyways. However, it's pretty misleading for the template to be called CopyablePersistent. I'll clean this up after merging