search

WiseLibs / better-sqlite3

The fastest and simplest library for SQLite3 in Node.js.
MIT License
5.22k stars 390 forks source link

Use node bullseye to build arm images #1216

Closed viceice closed 3 days ago

viceice commented 3 days ago

This will downgrade the used GLIBC to v2.31, so it's again compatibe with ubuntu 20.04.

rathboma commented 3 days ago

Omg, arbitrary glibc prebuilds would be fantastic.

2.28 seems very old now, but in particular the Ubuntu Extended Security Maintenance program (which is free for individuals) supports Ubuntu 18.04 until 2028, so a significant number of folks are going to be on 18.04 for a while.

Seeing as using an older version of glibc isn't a problem (just using a newer one), this would be fantastic.

@mceachen Would you be open to a PR that set up an environment with glibc 2.28+ as the compile target using the prebuild step you suggest above?

mceachen commented 3 days ago

@rathboma if the test suite can validate the prebuild works (so we'd use a docker image just like what this PR does), I don't see the downside to supporting Ubuntu 18 until it's really EOL (unless somehow it breaks newer more common builds, but I don't see that happening).