search

WiseTechGlobal / WTG.Analyzers

Analyzers from WiseTech Global to enforce our styles, behaviours, and prevent common mistakes.
Other
16 stars 3 forks source link

Update packages #155

Closed brian-reichle closed 2 years ago

brian-reichle commented 3 years ago

Only updated Roslyn as far as 3.3.1, this is because the 3.4 made a few more methods return nullable types and this produces a lot more errors. I'll upgrade to 3.4 separately and at a later time.

closes #149

brian-reichle commented 3 years ago

@yaakov-h, have you seen this before?

https://github.com/WiseTechGlobal/WTG.Analyzers/runs/2912126054?check_suite_focus=true#step:7:23535

   System.Reflection.ReflectionTypeLoadException : Exception of type 'System.Reflection.ReflectionTypeLoadException' was thrown.
Could not set up field 'Statement' due to: Could not load type of field 'Microsoft.CodeAnalysis.SQLite.Interop.SqlStatement:_rawStatement' (1) due to: Could not load file or assembly 'SQLitePCLRaw.core, Version=1.0.0.0, Culture=neutral, PublicKeyToken=1488e028ca7ab535' or one of its dependencies. assembly:/home/runner/work/WTG.Analyzers/WTG.Analyzers/bin/net472/Microsoft.CodeAnalysis.Workspaces.dll type:SqlStatement member:(null)
Could not load type of field 'Microsoft.CodeAnalysis.SQLite.Interop.SqlConnection:_handle' (0) due to: Could not load file or assembly 'SQLitePCLRaw.core, Version=1.0.0.0, Culture=neutral, PublicKeyToken=1488e028ca7ab535' or one of its dependencies.
Could not load type of field 'Microsoft.CodeAnalysis.SQLite.Interop.SqlStatement:_rawStatement' (1) due to: Could not load file or assembly 'SQLitePCLRaw.core, Version=1.0.0.0, Culture=neutral, PublicKeyToken=1488e028ca7ab535' or one of its dependencies.

I can't seem to reproduce it locally.

yaakov-h commented 3 years ago

I've seen it somewhere but I don't recall where or if/hoiw it was resolved.

Perhaps a xplat issue that doesn't reproduce on Windows?

brian-reichle commented 2 years ago

@yaakov-h I'm kinda tempted to drop macos & ubuntu

https://github.com/WiseTechGlobal/WTG.Analyzers/runs/4363779875?check_suite_focus=true#step:7:29

yaakov-h commented 2 years ago

I've managed to reproduce it and figured it out.

It's to do with running the net472 tests on non-Windows platforms through Mono.

net6.0 on those platforms works just fine.

We should probably only run the net472 tests on Windows, and run net6.0 on all platforms.