search

Wisembly / Totem

Changeset calculator between two states of a data
http://wisembly.github.io/Totem
MIT License
76 stars 6 forks source link

Remove all traces of reflection in ObjectSnapshot #34

Closed Taluu closed 8 years ago

Taluu commented 8 years ago

Merry christmas @krichprollsch and @lunika, if this works as it should... :heart:

Basically, removing all traces or dependencies towards Reflection for an ObjectSnapshot. Need to create more tests though with actual objects (see https://gist.github.com/Taluu/2ed4d1d71d5c0db291c4#gistcomment-1657274)

It's a little bit hackish though, even though it is still far more optimized like this.

Taluu commented 8 years ago

https://blackfire.io/profiles/compare/e3790154-b2fc-4fa8-b7cd-ed99f55fd271/graph Here is a comparision before / after. Basically, it's about 20 to 40% better :}

Taluu commented 8 years ago

Closing, as the target has changed (1.x instead of master)