Refactor main mecanism (a.k.a v2)

Wisembly / Totem

Changeset calculator between two states of a data

http://wisembly.github.io/Totem

MIT License

76 stars 6 forks source link

Refactor main mecanism (a.k.a v2) #38

Closed Taluu closed 3 years ago

Taluu commented 8 years ago

Ref #35, #16 and #5

[x] Create the snapshot interfaces
[x] implement the recursive
[x] Refactor how the object snapshots are built
[x] Refactor how the array snapshots are built
[x] Refactor how the collection snapshot is built
[x] Reflect changes on the Set
[ ] Implement "comparator"
[ ] Tests

coveralls commented 7 years ago

Coverage decreased (-16.8%) to 76.106% when pulling 8133834f89a4697deee1531f621c4e6f3847360f on Taluu:snapshotter into 870c63e9c9d43ed3dee76c8cc5d8ed9805f65e24 on Wisembly:master.

peter279k commented 5 years ago

The Travis CI build is failed because of the wrong PHPUnit namespace.

Using the PHPUnit\Framework\TestCase instead.

BTW, the commits are very large and it should squash all commits to one commit if possible.

Taluu commented 5 years ago

Hum, guess this is expected, as the last build dates from (almost) 2 years ago, as I didn't continue (even if it's on my todo list, but as I'm not currently using this lib...).

And I'm against squashing commits, and prefer to stay true to the atomic commits rule (makes it easier with bisects when looking out for bugs, have a proper history, ... and so on). :}

peter279k commented 5 years ago

Ok. It makes sense :).

Taluu commented 3 years ago

As it's been a while, I don't think continuing on this path is relevant anymore.

If I ever need to maintain this lib, I think I will do so differently than proposed right here.

Let's cleanup (But keep a branch for ref)