Expression: Detect file size and auto-adjust plot size if needed, etc.

[davidarndt]

• If input data has > 100 rows, use the automatic height adjustment right away ("Preview Full Height"). Then also add a message: "Plot dimensions were auto-adjusted. See below in Advanced Options for plot size settings." The message could be displayed right above the main plot -- you could use a renderText Shiny object in the main panel.
• If user switches from one example to another, or switches to upload a new file, reset the plot size settings to defaults.

[yongjiel]

OK, I handle it tonight.

On Sat, Apr 23, 2016 at 5:06 PM, davidarndt notifications@github.com wrote:

Assigned #64 https://github.com/sbabicki/heatmapper/issues/64 to @yongjiel https://github.com/yongjiel.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/sbabicki/heatmapper/issues/64#event-638821648

[yongjiel]

Functions are added to expression/server.R and expression/ui.R. All the new code has been pushed to origin/jack_branch.

[davidarndt]

Can we add:

• When the input data has > 100 rows and the height of rows is automatically adjusted, this should be done by programmatically selecting the "Preview Full Height" check box. If the user then de-selects this check box, the height should no longer be automatically adjusted.
• If the user changes the plot dimensions, hide the message "Plot dimensions were auto-adjusted..."

[yongjiel]

Ok, I follow it.

Jack

On Mon, Apr 25, 2016 at 8:43 AM, davidarndt notifications@github.com wrote:

Can we add:

• When the input data has > 100 rows and the height of rows is automatically adjusted, this should be done by programmatically selecting the "Preview Full Height" check box. If the user then de-selects this check box, the height should no longer be automatically adjusted.
• If the user changes the plot dimensions, hide the message "Plot dimensions were auto-adjusted..."

— You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub https://github.com/sbabicki/heatmapper/issues/64#issuecomment-214366025

[yongjiel]

change expression/ui.R and server.R. Now if nrow(file) > 100, the app will initiate the function 'Plot full size' in the 'Advanced options', if <, then still use the default. After uncheck the 'Plot full size', still use the default (the scale pixels value to show image)."

[davidarndt]

It looks like the behavior is still the same as before (unchecking "Preview Full Height" does not stop auto-scaling and hide the message). jack_branch was merged with master and everything was updated on the production server.

[yongjiel]

It is because the show/hide advanced options button hiding all the options. Now I updated the code a little. All the functions work except that the "show/hide advanced button" not work properly. We can use this code first and fix the button later. Code is updated in jack_branch

On Mon, Apr 25, 2016 at 6:37 PM, davidarndt notifications@github.com wrote:

Reopened #64 https://github.com/sbabicki/heatmapper/issues/64.

— You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub https://github.com/sbabicki/heatmapper/issues/64#event-640818332

[yongjiel]

Now the button can work properly. Everything looks good.

[davidarndt]

Two issues:

• If the user checks "Preview Full Height" again, we should not show the message "Plot dimensions were auto-adjusted..." It should only show the first time, before the user uses the plot dimension controls.
• If I have the Advanced Options section closed, then choose Example 2, then open the Advanced Options section, Heatmapper will try to re-draw the squished heat map and then re-draw the auto-adjusted heat map. It should not have to re-draw anything just because I opened the Advanced Options section.