search

Wisling / tibiaauto

Tibia Auto is made to excel in the automation of various aspects of the playing the MMORPG Tibia
31 stars 16 forks source link

Dialog windows of modules crash application #1

Closed dmarszk closed 8 years ago

dmarszk commented 8 years ago

According to Wisling, any child afx window opened by dialog window ends up crashing TA.

dmarszk commented 8 years ago

I'm actually finding it hard to reproduce when using eaca85de053253d7e6ccdfc93bcaf60a22e7dc7b as head. @Wisling please advise.

Wisling commented 8 years ago

I checked and it's only in the debug build of TA.

dmarszk commented 8 years ago

Could you provide me with steps to reproduce?

2016-04-05 14:44 GMT+02:00 Wisling notifications@github.com:

I checked and it's only in the debug build of TA.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/Wisling/tibiaauto/issues/1#issuecomment-205782986

Wisling commented 8 years ago

Yeah, if you don't experience it, then let me know. Build TA under Debug. Run TA & connect to any Tibia session. Go to spells, healing, and try and edit the exura sio Heal List. If there is an error before the window appears, then that's what I'm referring to.

dmarszk commented 8 years ago

Thanks. I found the culprit. All modules are being derived from CWinApp. It's pointless, because all modules are actually DLLs acting as hidden dialogs. CWinApp makes MFC think each module is a separate application, and tries to assign the child dialog boxes to it. I'll fix it after merging current patches.

dmarszk commented 8 years ago

Fixed in d08e5d843d05cfa21e42b47a5af5112c0a2a8193

Wisling commented 8 years ago

That probably explains why tabbing didn't work either. I may need to undo some work-arounds :P