search

Wisling / tibiaauto

Tibia Auto is made to excel in the automation of various aspects of the playing the MMORPG Tibia
31 stars 16 forks source link

Stryku dev #4

Closed stryku closed 8 years ago

stryku commented 8 years ago

Added possibility to drop more than one empty flask at once

stryku commented 8 years ago

Ok so I fixed formatting in my code. I noticed that everywhere in my code there are spaces not tabs but in other code in some places are tabs. I think I wont check whole project and change tabs to spaces so I'll leave it as it is.

stryku commented 8 years ago

Forgot change in some files. Now everything should be ok

dmarszk commented 8 years ago

Did you use uncrustify? The config file for it is in the root dir of repo. It would fix all indents for you. There is even more broken indents in last commits.

stryku commented 8 years ago

Ok now I used it. I'm working with it for the first time so please check if everything is ok.

dmarszk commented 8 years ago

Looks great. You ommited adding "other/flaskMoreThan" to getConfigParamName. I'll fix that, among some other stuff that came out after using Uncrustify.

dmarszk commented 8 years ago

Squashed into e9396ea198b754f10f01fb28b9b6c4150dc8513c with minor fixes and merged in 74d7481e16b85818ebe49f0031737f84ece05ca9

Wisling commented 8 years ago

Hey Stryku. Your addition looks great! I changed the logic to use ">=" instead of ">" and change the variable to dropFlasksAt instead of flaskMoreThan. It also saves the setting properly :) Nice work.