Wissance / WebApiToolkit

A set of useful C# reusable classes and components that could be used with any Net Core Web application IT ALLOW TO REDUCE AMOUNT OF CODE when IMPLEMENTING REST API (see examples in README)
https://wissance.github.io/WebApiToolkit/
Apache License 2.0
14 stars 3 forks source link

Some issues with examples #2

Closed jonchengkuo closed 2 years ago

jonchengkuo commented 2 years ago

Hi Ushakov,

I like your WebApiToolkit. I found a few minor issues on the project home page (https://github.com/Wissance/WebApiToolkit):

  1. In the Requirements section, "labrary" is misspelled.
  2. In the GroupController example, the class constructor name is incorrect.
  3. It'll be better if you can shown how the GroupEntity class implements IModelIdentifiable.

I also have the following comments on WebApiToolkit:

  1. Base Controller: I personally think that passing the Manager object into the base controller via a constructor is easier to understand. i.e., public GroupController(GroupManager manager) : base(manager) { }

  2. Order of type parameters is inconsistent between base controller and base manager. BasicReadController<GroupDto, GroupEntity, int> ModelManager<GroupEntity, GroupDto, int>

Joncheng

EvilLord666 commented 2 years ago

@jonchengkuo , thank you for useful project review. I'll correct documentation asap and also i'll make example project without WebApiToolkit and with it. And also i will clarify order of base classes template paramters. Thank you.

EvilLord666 commented 2 years ago

@jonchengkuo , I've prepared a full example how to use (whole solution) you could check it here: https://github.com/Wissance/WeatherControl

EvilLord666 commented 2 years ago

Readme updated using examples from link above

EvilLord666 commented 2 years ago

Examples were updated and show full Controller && Manager clases, for reasonable notes created to issues: #6 , #7