Closed jonchengkuo closed 2 years ago
@jonchengkuo , thank you for useful project review. I'll correct documentation asap and also i'll make example project without WebApiToolkit and with it. And also i will clarify order of base classes template paramters. Thank you.
@jonchengkuo , I've prepared a full example how to use (whole solution) you could check it here: https://github.com/Wissance/WeatherControl
Readme updated using examples from link above
Examples were updated and show full Controller && Manager clases, for reasonable notes created to issues: #6 , #7
Hi Ushakov,
I like your WebApiToolkit. I found a few minor issues on the project home page (https://github.com/Wissance/WebApiToolkit):
I also have the following comments on WebApiToolkit:
Base Controller: I personally think that passing the Manager object into the base controller via a constructor is easier to understand. i.e., public GroupController(GroupManager manager) : base(manager) { }
Order of type parameters is inconsistent between base controller and base manager. BasicReadController<GroupDto, GroupEntity, int> ModelManager<GroupEntity, GroupDto, int>
Joncheng