search

With-the-Ranks / Spoke

With the Rank's fork of Politics Rewired's fork of Spoke
GNU General Public License v3.0
0 stars 1 forks source link

refactor(campaign): simplify subtypes #15

Open ajohn25 opened 7 months ago

ajohn25 commented 7 months ago

Description

This PR cleans up some typing across a few places:

  1. CampaignContactTag: Removing unused created at and updated at fields for simplified conversion to Tag type where needed
  2. CampaignVariable: Removing unused pagination
  3. CampaignInput: Use arrays of non-optional canned responses and campaign contacts
  4. campaign.ts: misc. typing

Motivation and Context

Prep for bug fix PR to come

How Has This Been Tested?

This has been tested locally:

  1. Tags - texter, message review (there is an existing bug to fix here
  2. Campaign Variables - texter, campaign builder, script preview
  3. Campaign Builder - Loading contacts, adding canned responses

Screenshots (if appropriate):

Documentation Changes

Checklist: