search

WithCandour / statamic-aardvark-seo

Candour's SEO addon for Statamic
https://statamic.com/marketplace/addons/aardvark-seo
11 stars 18 forks source link

Upgrading to 2.0.16 breaks static site generator #100

Closed kyranb closed 2 years ago

kyranb commented 3 years ago

Each page has the following error:

[✘] /privacy-policy (Call to a member function raw() on string)

globalexport commented 2 years ago

The stacktrace starts at https://github.com/WithCandour/statamic-aardvark-seo/blob/e658bd5b614838d03c8042341956d70a55e17ff9/src/Parsers/PageDataParser.php#L49

$value is the string.

globalexport commented 2 years ago

I tested the downgrade to 2.0.14 and got rid of the errors.

globalexport commented 2 years ago

Sorry, I missed the commit hash. Thanks a lot! :)

AndrewHaine commented 2 years ago

Hi @globalexport ,

Yep, we've identified and applied the fix, apologies I think GitHub closed it prematurely since I mentioned it in the commit message. The fix will be released in 2.0.17 later today.

The issue was that we were missing the blueprint fields since our listener was excluding them if the app was running in the console, I've removed this check which has fixed the issue and I don't see a use case where having the blueprints when running in the console would cause an issue - this might be revisited in the future though when we have more info.

Thanks, Andrew