WithCandour / statamic-aardvark-seo

Candour's SEO addon for Statamic
https://statamic.com/marketplace/addons/aardvark-seo
11 stars 18 forks source link

Timeout error from statamic/cms v4.32.0 onwards (after upgrade) #164

Open globalexport opened 10 months ago

globalexport commented 10 months ago

Good day,

After upgrading a Statamic site from v3 to v4, I was able to isolate this addon as being incompatible to statamic from v4.32.0 onwards. The last functioning version is v4.31.0. v4.32.0 is resulting in a PHP timeout when rendering tags like

 {{ aardvark-seo:body }}

due to https://github.com/WithCandour/statamic-aardvark-seo/blob/28400082c59c6afa8ed8af6ce106aa9633a24b27/src/Tags/AardvarkSeoTags.php#L54

not being resolved in time.

mkwia commented 10 months ago

Thank you fro your report @globalexport . The team will review this as soon as possible

CandourDevs commented 8 months ago

Hi @globalexport , we raised an issue to Statamic to flag what we think is causing the incompatibility. We're also working to resolve this ourselves whilst Statamic works to release the fix.

If you'd like to see further information on the raised issue, you can find more information here (https://github.com/statamic/cms/issues/9105).

duncanmcclean commented 8 months ago

@globalexport I'm struggling to replicate the issue on the Statamic side. Are you experiencing this issue on all entries or just some of them? Are you able to replicate on a fresh site?

globalexport commented 8 months ago

Hi @duncanmcclean The error was on all pages because {{ aardvark-seo:body }} is included in the main layout file. I did not test it on a fresh install at the time because of the evident change of behavior between upgrades of Statamic.

I can confirm now that it is not happening when adding aardvark tags into the layout of an empty installation. It probably needs other cms elements to be active to enforce the timeout.

I am going to replicate the error in a few days to find out more about the state shortly before the timeout.

duncanmcclean commented 6 months ago

@globalexport Were you able to replicate the error in a fresh site?

globalexport commented 6 months ago

Hi @duncanmcclean ! Sorry, that I did not inform you about the latest development.

As mentioned in my last post, I was not able to reproduce the issue in a fresh site. I planned to dig into the project more thoroughly, but needed to hand over the affected project to the client. I am unsure at this time when I can continue to work on this project.

It seems to be a tricky edge-case possibly related to the replicator component which was quite complex in the project.

Should I keep the issue open? @CandourDevs @mkwia ?

schrmc14 commented 6 months ago

I'm running into the same issue and have reverted back to v4.31. While I haven't dug into it further, my case somewhat fits what's mentioned here >> https://github.com/statamic/cms/issues/9105#issuecomment-1973295434 in that I do have something like Bard > Fieldset > Replicator > Fieldset > Replicator > Fieldset > Link (many nested replicators with a Link)

leganz commented 4 months ago

Is there any update on that? We are still stuck with version 4.31 and would like to continue update to the latest statamic version. But this problems blocks that unfortunately :/

CandourDevs commented 4 months ago

Thank you for the comments and additional information.

We will be reviewing this ticket more closely later this month and will send you an update shortly.

novu-developers commented 4 months ago

Just wanted to confirm this issue. We're also stuck here on 4.31, and would like to move forward to the latest 4.x version. Please, also consider adding support for Statamic 5. @CandourDevs Thanks for all your effort on this issue!

DKleiweg commented 2 months ago

Is there any progress on this issue? Still waiting on it so that i can update our Statamic instances beyond v4.32.0.