WithCandour / statamic-aardvark-seo

Candour's SEO addon for Statamic
https://statamic.com/marketplace/addons/aardvark-seo
11 stars 18 forks source link

Github -> settings not stored? #76

Closed HRR1337 closed 3 years ago

HRR1337 commented 3 years ago

Hi there,

I have an live site and an develop location (local). When I change general settings in live or develop side, it wont push it to github (and therefore dosn't deploy to live or isn't visible in my local dev).

Is there an way to fix this?

Thanks!

devonbeard commented 3 years ago

I also have been having this problem. Just realized the settings don't get saved, so the settings get reverted to defaults on production.

devonbeard commented 3 years ago

@HRR1337 There is a closed issue, stating to remove the settings files from the gitignore to be able to save these settings. I tried that and it worked for me. https://github.com/WithCandour/statamic-aardvark-seo/issues/74

mikemartin commented 3 years ago

@HRR1337 You could update /storage/statamic/.gitignore with:

/*
!/addons/
!.gitignore
brad-sf commented 3 years ago

Or just manually track the Aardvark SEO files...

git add storage/statamic/addons/aardvark-seo/* -f
Changes to be committed:
    new file:   storage/statamic/addons/aardvark-seo/aardvark_general.yaml
    new file:   storage/statamic/addons/aardvark-seo/aardvark_sitemap.yaml
    new file:   storage/statamic/addons/aardvark-seo/aardvark_social.yaml
AndrewHaine commented 3 years ago

Closing in favour of proposed solutions, thanks all!

ncla commented 2 years ago

This seems like an unexpected behavior for someone who uses the Statamic Git integration. I think default location should be changed or this should be documented.

If mikemartin's .gitignore change still didn't track the storage addons directory, then you can try this one, editing /storage/statamic/.gitignore:

*
!.gitignore
!addons/
!addons/**/*
AndrewHaine commented 2 years ago

Thank you for the feedback on this one, confirmed that moving the location of stored Aardvark settings will be changed in the future to ensure that it is accessible for the git integration. This is likely to be in Aardvark v2.1