gk0us
commented
5 years ago In v1.3.2 I get a similar error.
[*] Checking connection with device...
[+] Already connected to: 127.0.0.1
[D] Creating temp folder: /var/root/needle/
[D] [REMOTE CMD] Remote Command: if [ -d /var/root/needle/ ]; then echo "yes"; else echo "no" ; fi
[+] Target app: com.example.app
[*] Retrieving app's metadata...
[D] Copying the plist to temp: '/private/var/containers/Bundle/Application/52A5FC17-C611-4DA1-9666-306E371868AF/Example App.app'"'"'/Info.plist' -> /home/test-user/.needle/tmp/plist
[*] Pulling: '/private/var/containers/Bundle/Application/52A5FC17-C611-4DA1-9666-306E371868AF/Example App.app'"'"'/Info.plist' -> /home/test-user/.needle/tmp/plist
[D] Downloading: "'/private/var/containers/Bundle/Application/52A5FC17-C611-4DA1-9666-306E371868AF/Example App.app'"'"'"'"'"'"'"'"'/Info.plist'" -> /home/test-user/.needle/tmp/plist
[D] [LOCAL CMD] Local Command: sshpass -p "Password" scp -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no -P 2222 root@127.0.0.1:"'/private/var/containers/Bundle/Application/52A5FC17-C611-4DA1-9666-306E371868AF/Example App.app'"'"'"'"'"'"'"'"'/Info.plist'" /home/test-user/.needle/tmp/plist
------------------------------------------------------------
Traceback (most recent call last):
File "/home/test-user/mobileScripts/needle/needle/core/framework/module.py", line 111, in do_run
pre = self.module_pre()
File "/home/test-user/mobileScripts/needle/needle/core/framework/module.py", line 147, in module_pre
if self.app_check() is None: return None
File "/home/test-user/mobileScripts/needle/needle/core/framework/framework.py", line 693, in app_check
self.APP_METADATA = Framework.APP_METADATA = self.device.app.get_metadata(app)
File "/home/test-user/mobileScripts/needle/needle/core/device/app.py", line 17, in get_metadata
return self._retrieve_metadata()
File "/home/test-user/mobileScripts/needle/needle/core/device/app.py", line 26, in _retrieve_metadata
plist_info = self._device.remote_op.parse_plist(plist_info_path)
File "/home/test-user/mobileScripts/needle/needle/core/device/remote_operations.py", line 219, in parse_plist
content = Utils.plist_read_from_file(plist_copy)
File "/home/test-user/mobileScripts/needle/needle/core/utils/utils.py", line 162, in plist_read_from_file
plist = biplist.readPlist(path)
File "/home/test-user/.local/lib/python2.7/site-packages/biplist/__init__.py", line 105, in readPlist
pathOrFile = open(pathOrFile, 'rb')
IOError: [Errno 2] No such file or directory: '/home/test-user/.needle/tmp/plist'
------------------------------------------------------------
[!] IOError: [Errno 2] No such file or directory: '/home/test-user/.needle/tmp/plist'
flamecopper
poldenais
Issue
It seems that needle does not properly handle spaces in the name of the application when dealing with filepaths.
Expected behaviour
Needle should use the backlash '\' escape character to escape out spaces in the filepath.
Actual behaviour
Needle uses HTML encoding, inserting '%20' for spaces in the name of an application.
Steps to reproduce
needle error logs
Ensure verbose and debug mode are enabled:
It might be difficult to tell from above (I am forced to remove the application name), but the application has a space in the name. Needle is trying to access the app filepath, shown as
/private/var/containers/Bundle/Application/D4EE87E5-FBDD-49D2-B33A-8898FF27E257/<redacted>%20<redacted>.app. However, the space should not be encoded, it should be escaped like this:/private/var/containers/Bundle/Application/D4EE87E5-FBDD-49D2-B33A-8898FF27E257/<redacted>\ <redacted>.app.A non-redacted example would be
/private/var/containers/Bundle/Application/D4EE87E5-FBDD-49D2-B33A-8898FF27E257/My%20Application%20Name.app. This should be handled by needle as/private/var/containers/Bundle/Application/D4EE87E5-FBDD-49D2-B33A-8898FF27E257/My\ Application\ Name.app.Let me know if this is still confusing, and I can try to explain further.
Environment
Workstation Operating System
Kali Linux 2.0 Rolling
Python Version
Python 2.7.13
Device iOS Version
iOS 10.2