search

WithSecureLabs / needle

The iOS Security Testing Framework
https://mobiletools.mwrinfosecurity.com/
Other
1.33k stars 284 forks source link

Update app.py #204

Closed Yogehi closed 6 years ago

Yogehi commented 6 years ago

fixed an issue where if the "bundle executable" name is more than one word, needle inserts random single quotes and double quotes between ".app" and "/Info.plist"

example, before this fix, when i try to pull the meta data for all app called "my app", needle uses the following command locally:

sshpass -p "alpine" scp -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no -P 2222 root@127.0.0.1:"'/private/var/containers/Bundle/Application//my app.app'"'"'"'"'"'"'"'"'/Info.plist'" /root/.needle/tmp/plist

after this fix, the local command looks like the following:

sshpass -p "alpine" scp -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no -P 2222 root@127.0.0.1:"'/private/var/containers/Bundle/Application//my app.app/Info.plist'" /root/.needle/tmp/plist

marco-lancini commented 6 years ago

This PR is not atomic, as it propose changes in different components. I suggest to close it and re-propose it splitted down in different PRs

Yogehi commented 6 years ago

Whoah not sure what happened...I'll close this PR and open a new one.