Closed tghosth closed 7 years ago
Hi @tghosth, thanks for reporting this.
Needle now supports a new global option (OUTPUT_FOLDER
) which can be used to define what folder is going to be used globally to store the output created by the modules.
In addition, there is still the possibility to customize the output of each module by modifying its local OUTPUT
variable.
Now, the first module run after startup will trigger a check that will test if the global output folder exists and is empty. This does not apply to the folders/files specified manually in the options of a module (especially cause it can be tedious to manually confirm the operation every time).
Does it make any sense to you? I would like to hear your opinion as well.
hi @marco-lancini, firstly I think the global output feature is a great idea and will save a lot of time :)
However, if I run a module having specified a different output folder, it doesn't make sense to me that it checks the global output folder. To my mind, it should check the global output folder the first time it uses the global output folder and if I run a module with a different folder, the check should be deferred.
Thanks,
Just deferred or would you suggest to check also that "different" folder?
Good question. One idea would be to have a global option that basically controls whether the user gets prompted about non-empty output directories and that applies everywhere.
Hi @tghosth, do you still want to implement this?
To be honest I don't remember what the most recent version does for this. You could leave this open as a low priority fix or just close it for now if you prefer. Unfortunately I won't have time to look at it in the next few weeks...
Issue
Module checks if files exist in wrong output directory
Expected behaviour
When you run a module, it should check if files already exist in the output directory which was specified before running the module and warns appropriately.
Actual behaviour
When you run a module, it checks if files already exist in the default/global output directory even if a different output directory was specified before running the module.
See:
[D] Setup local output folder: /root/.needle/output
in the log belowNote that the files still get saved in the expected directory.
Steps to reproduce
See logs
needle error logs
Environment
Workstation Operating System
Kali 2016.2
Python Version
2.7.12+
Python Packages (
pip freeze
)Device iOS Version
9.2