WittleWolfie / CharacterOptionsPlus

Expanded character options for Pathfinder: Wrath of the Righteous
MIT License
16 stars 4 forks source link

[BUG] #134

Closed CaptOcto closed 1 year ago

CaptOcto commented 1 year ago

Attach a Bug Report https://www.dropbox.com/s/dmhg5xd8bkmu7ww/c54hq5fo.mew?dl=0 https://www.dropbox.com/s/k7mirywsray3q9s/Manual_12_Drezen__5_Neth__XI__4715__11_55_29.zks?dl=0

Describe the bug Frozen Caress doesn't add Cold descriptor for purpose of items (Elemental Imbuement) or abilities (Dragonblood: White/Silver) for Vampiric Touch and Hellfire Ray (and presumably other spells).

To Reproduce Steps to reproduce the behavior:

  1. Activate Frozen Caress.
  2. Cast a non-cold touch spell.
  3. Observe behaviour.

Expected behavior Adding the Cold descriptor should allow these spells to benefit from added elemental damage from abilities or items.

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

WittleWolfie commented 1 year ago

I'll take a look but this probably won't get fixed. The major issue is that the way you change the descriptor happens more or less simultaneously / after a effects like those. It's a huge technical challenge to do otherwise and I think you get the same behavior from Elemental Spell.

WittleWolfie commented 1 year ago

This appears to be working correctly:

image

image

There's probably some confusion here because Frozen Caress does not change the damage type to Cold, just adds the descriptor. That means the effects of Elemental Imbuement do not actually apply to the spell's primary damage; they apply only to the bonus 1d4.

For Draconic Bloodline the effect does apply. Aside: Hard to say exactly why that particular damage instance gets bonuses twice but so much is going on here I assume that's expected and confirmed it's nothing to do w/ COP.