search

Wiwiweb / FactorioMilestones

Factorio Mod for tracking your milestones
GNU General Public License v3.0
7 stars 13 forks source link

Fix / Extend Omni support #15

Closed Cereal-Sam closed 1 year ago

Cereal-Sam commented 1 year ago
Wiwiweb commented 1 year ago

At this point in the stage of the mod's life, I'd rather the milestones presets get handled by their own mods, since they are more familiar with their own mod and it is less maintenance for me.

Can you make a PR for Omniscience instead?

This comment at the top of presets.lua should explain how to use the remote interface. Here's also an example from Exotic Industries.

Sorry for the trouble.

Cereal-Sam commented 1 year ago

Tbh i would prefer to have it together. This is likely a one time thing, so having it either on my or your side would make sense for me.

What we could do as well is having the basic support on your side and the extended "features"/milestones on mine to have a logical split. E.g. leave it as it is, fix omniscience and add omnimatters resources (since that´s required for nearly all other omni mods). I could add additional Milestones to omni then if wanted/required.

Wiwiweb commented 1 year ago

Sorry I didn't realize you were the developer for Omniscience. If you provide milestone presets on your side, the default presets in Milestones will be overwritten to what you provide. Essentially making the preset on my side redundant, and I would remove it at some point in a future update.

This is what happened with Seablock: Added on their side, and removed on my side.

This is better for you too because it gives you full control over the preset, you can modify it however you want and whenever you want without waiting for me to do a release, and you can also customize it based on your mod's configuration (for example Seablock changes the preset based on the default landfill color selected by the player).