search

Wiwiweb / FactorioMilestones

Factorio Mod for tracking your milestones
GNU General Public License v3.0
9 stars 15 forks source link

Add a dynamic addon preset for Infused Science (Fixed) and a framewor… #9

Closed nihilistzsche closed 1 year ago

nihilistzsche commented 2 years ago

…k for dynamic presets.

This one is a bit meatier than the others, and I'm open to feedback and suggestions on how to improve it if necessary. On my game with over 500 mods, the loop in the build_func only takes a couple of seconds to execute so I don't think its a huge concern as it is only run when the milestones are evaluated.

nihilistzsche commented 2 years ago

Don't merge this yet please, I have some cleanup planned for it and having some computer issues I need to solve before I can update it.

Wiwiweb commented 2 years ago

I'll have to review this and give you feedback later, been quite busy lately. I'm not sure yet if the preset is worth the extra complexity.

nihilistzsche commented 2 years ago

This isn't where I want to leave this, it's just that right after I submitted these PRs, my home server what hosts all of my things broke and Im on hour 310 of trying to repair it and I have no clue when or if it will be repaired, and Im unable to update anything until it is.

nihilistzsche commented 1 year ago

Hey, sorry I didnt get back sooner, my server finished repairing itself a couple of months ago, and I just got factorio working again about two weeks ago. Anyways, I respect your decision to close this, and will just keep it locally, but I want to provide some more info for context:

(Okay, so the issue is the version I had saved was 1.3.2, and youre up to 1.3.13 now, so I had to rebase it, and Im gonna get the branches fixed and push to my branch again with some recent changes.)

img-2023-01-09-030759

Additionally, while this may seem like complex Lua, I served as a professional software engineer for WoW for 4/12 years, at least 75% of which was writing in Lua, so I would be a professional Lua programmer, and this is actually a rather simple API for creating an easily extensible, dynamic framework that would not just benefit IS(F) but any mod that added dynamic items could have milestones generated. Like for example, I could see adding a dynamic preset for deadlock stacking for when you first stack an item that has a milestone already, and then the normal x10 additionals potentially.