Wizcorp / frontrunner

Automated HAProxy reconfiguration for Marathon
https://github.com/Wizcorp/frontrunner
MIT License
57 stars 2 forks source link

Use https://www.npmjs.com/package/mesos #15

Open stelcheck opened 9 years ago

stelcheck commented 9 years ago

https://www.npmjs.com/package/mesos provides the API to operate with the Marathon cluster, which would make the code of this project easier to understand I think @MiLk any thoughts?

MiLk commented 9 years ago

Should we really use a dependency for one API call? https://github.com/silas/node-mesos#marathontaskscallback https://github.com/Wizcorp/frontrunner/blob/develop/lib/marathon.js#L31-L48

Not sure it makes sense.

stelcheck commented 9 years ago

We could get rid of zookeeper and get events through that library it appears.

MiLk commented 9 years ago

With event subscriptions? https://github.com/silas/node-mesos#marathoneventsubscriptionregisteropts-callback https://mesosphere.github.io/marathon/docs/rest-api.html#event-subscriptions

stelcheck commented 9 years ago

Yes. Since Marathon appears to be providing all we need and them some, it seems to be it would be more natural to follow their ways.