Closed MarcEtienneDery closed 6 years ago
@MarcEtienneDery thanks for including this!
@ronkorving I would like to get #40 in first. Afterwards, we can adopt the same pattern in having a fallback when pending_renewal_info
is not found. I have plenty of active receipts that don't have this field so a discrete fallback would explain why the value may be null or some other default value.
@KLVTZ #40 is already merged, do you have plan to merge this?
@sarunw Can you review how #40 has fallbacks when a field is not available? In other words, we should check to see if this field exists before including it. I have plenty of active receipts that don't have this field so a discrete fallback would explain why the value may be null or some other default value.
@KLVTZ If this field is not present it will be undefined just like latestExpiredReceiptInfo
what behavior do you want if it not present? Remove the key or set it to null.
This is not my PR, but happy to help create one to make this happen.
@KLVTZ handling this like latestExpiredReceiptInfo
is the way to go.
pending_renewal_info
won't be used for the common fields so it can just be undefined or null.
In #40 we decided to use null if data is not available. So I guess we could use null here too for both latestExpiredReceiptInfo
and pending_renewal_info
I made new PR here https://github.com/Wizcorp/node-iap/pull/48
I think we should merge #48 instead of #46.
Thanks for your contribution! This LGTM. Wouldn't mind someone else signing off on it too before I merge it though.
cc @KLVTZ