Closed scottspork closed 9 years ago
Dear god, sorry for being late on this one. If you can confirm this works, I will gladly merge. Might not have a lot of time for testing myself, unfortunately...
@stelcheck make test
passes when I run it against a pivotal project. There are some JSHint errors that I fixed in a separate branch. My smoke tests with core pivotal APIs worked as expected.
Could you submit a PR with the JSHint fixes? I'll make sure to merge ASAP
Sure thing - submitted. I suggest moving to JSHint in a follow-up (the project is using JSLint). Some of the lint warnings are not actionable or relevant (like var
in a for statement), so I ignored them for now.
@stelcheck Any blockers to merging this?
Me obviously :/ Sorry, I'll try to get to test it within the next 24 hours
@stelcheck This should be good to go - if we could include #33 in 0.2.1 that would improve some of the documentation.
This PR only has the version bump left in terms of code change. I'll make the bump as soon as we get some of the remaining issues out of the way (see https://github.com/Wizcorp/node-pivotal/pull/35)
@stelcheck @ronkorving any chance you could merge this version bump? The old dependencies result in API breaks. One example is the
sanitize
method was removed fromvalidator
, resulting inpivotal.addStoryComment
being broken.