search

Wizcorp / node-pivotal

NodeJS API library for PivotalTracker
44 stars 20 forks source link

Version bump to fix dependencies #32

Closed scottspork closed 9 years ago

vanm commented 10 years ago

@stelcheck @ronkorving any chance you could merge this version bump? The old dependencies result in API breaks. One example is the sanitize method was removed from validator, resulting in pivotal.addStoryComment being broken.

stelcheck commented 10 years ago

Dear god, sorry for being late on this one. If you can confirm this works, I will gladly merge. Might not have a lot of time for testing myself, unfortunately...

vanm commented 10 years ago

@stelcheck make test passes when I run it against a pivotal project. There are some JSHint errors that I fixed in a separate branch. My smoke tests with core pivotal APIs worked as expected.

stelcheck commented 10 years ago

Could you submit a PR with the JSHint fixes? I'll make sure to merge ASAP

vanm commented 10 years ago

Sure thing - submitted. I suggest moving to JSHint in a follow-up (the project is using JSLint). Some of the lint warnings are not actionable or relevant (like var in a for statement), so I ignored them for now.

vanm commented 10 years ago

@stelcheck Any blockers to merging this?

stelcheck commented 10 years ago

Me obviously :/ Sorry, I'll try to get to test it within the next 24 hours

vanm commented 9 years ago

@stelcheck This should be good to go - if we could include #33 in 0.2.1 that would improve some of the documentation.

stelcheck commented 9 years ago

This PR only has the version bump left in terms of code change. I'll make the bump as soon as we get some of the remaining issues out of the way (see https://github.com/Wizcorp/node-pivotal/pull/35)