search

Wizcorp / phonegap-facebook-plugin

The official plugin for Facebook in Apache Cordova/PhoneGap
Other
1.91k stars 2.01k forks source link

"Crosswalk" not compatible with "phonegap-facebook-plugin" #1136

Open bau720123 opened 8 years ago

bau720123 commented 8 years ago

Hello all

if I only use the plugin，it will build Android success

<preference name="phonegap-version" value="cli-5.2.0" />
<preference name="android-build-tool" value="gradle" />
<gap:plugin name="phonegap-facebook-plugin" source="plugins.cordova.io" version="0.12.0">
 <param name="APP_ID" value="XXXXX" />
 <param name="APP_NAME" value="YYYYY" />
</gap:plugin>

but if I add crosswalk with your plugin，it will become build fail on android

<preference name="phonegap-version" value="cli-5.2.0" />
<preference name="android-build-tool" value="gradle" />
<gap:plugin name="phonegap-facebook-plugin" source="plugins.cordova.io" version="0.12.0">
 <param name="APP_ID" value="XXXXX" />
 <param name="APP_NAME" value="YYYYY" />
</gap:plugin>
<gap:plugin name="cordova-plugin-crosswalk-webview-pgb-adapt" source="npm" version="1.4.0-dev-5" />

just feedback and hope can solve the issue thanks anyway!!!

dnoliver commented 8 years ago

Just a comment, maybe it is not the root cause of this failure, but I think crosswalk is not compatible with cordova-cli 5.2.0 yet.

davidmuldergc commented 8 years ago

same with push plugin

don't understand alot of it. but i read that facebook plugin inserts a script/code and the other plugins as well which conflicts with double scripts/plugins. a dependency should solve this ?

hopefully it says more to you then it says to me. It seems that push plugin uses dependency and if facebook plugin did the same i wouldn't conflict anymore

bau720123 commented 8 years ago

hi @davidmuldergc I have been post some information about push plugin https://github.com/phonegap/phonegap-plugin-push/issues/199