search

Wizcorp / phonegap-facebook-plugin

The official plugin for Facebook in Apache Cordova/PhoneGap
Other
1.91k stars 2.01k forks source link

[Discuss][Android] Remove unnecessary files from platforms/android folder #1177

Open sgrebnov opened 8 years ago

sgrebnov commented 8 years ago

This applies to develop branch:

We've recently switched to gradle dependency for Android so most of the files in platftorms/android/folder are not actual and not required anymore. Propose to remove everything except the following files:

 \android\src\org\apache\cordova\facebook\ConnectPlugin.java
 \android\res\values\facebookconnect.xml
 \android\README.md

I'm wondering if there are people using CordovaLib, platform_www, etc from that folder for development or any other purpose. Please note, FacebookSDK in that folder is not the same version as plugin uses.

PS. Unused files and libraries may lead to confusion/misunderstanding, adds additional rump up complexity for new contributors and increases plugin size.

sgrebnov commented 8 years ago

I'll be able to clean up that folder if we agree

aogilvie commented 8 years ago

If its not the same version that is another issue. I'm ok with removal since gradle is the chosen format.

I fucking despise gradle. Why grunt is not used is a separate discussion not for airing here.