Wizcorp / phonegap-facebook-plugin

The official plugin for Facebook in Apache Cordova/PhoneGap
Other
1.91k stars 2k forks source link

Support for Intel XDK Cordova builds #598

Open arnesikstrom opened 10 years ago

arnesikstrom commented 10 years ago

Intel just released a new version of the Intel XDK that supports Cordova Third-Party plugins. https://software.intel.com/en-us/html5/articles/release-notes-information-intel-xdk/

I would be great to have this plugin work in that build system. I have tried but it fails during "installation". I expect that the requirement is that the plugin builds with CLI directly after download.

For me to get the plugin (0.7.0) to build in CLI after download is the following: echo android.library.reference.1=FacebookLib >> platforms\android\ant.properties cd platforms\android\ ant clean cd FacebookLib ant clean ant release cd ...... cordova build android

Is this something that can be put on the todo list?

arnesikstrom commented 10 years ago

The installation error was due to that the parameters could not be set in the "Repo URL" field as it could with the CLI. The workaound is to create a "intelxdk.config.additions.xml" file with the following:

`

</intelxdk:plugin>`

arnesikstrom commented 10 years ago

I got a suggestion from the support forum at Intel to create a depency plugin. Is this possible to do for this plugin as well?

Quote from IntelPaulF: "-- the second method I provided to you works, (the first one may be working, but we didn't fully verify that), but... -- ...there is a Facebook JAR file that needs to be added to the plugin, which is not part of the plugin, that's the reason for your extra steps in one of your earlier posts (specifically, this line "echo android.library.reference.1=FacebookLib >> platforms\android\ant.properties") -- there is a similar problem with plugins that require Google Play Services, that has been solved by creating a "dependency" plugin, you can see that dependency plugin here: https://github.com/MobileChromeApps/google-play-services -- if you create a similar dependency plugin, but based on the Facebook JAR library, and then include it, as well as the Facebook plugin, the problem should be solved (we did not have time to fully verify) "

aogilvie commented 10 years ago

@frostyelkarne Automated steps have been added to the Android README https://github.com/Wizcorp/phonegap-facebook-plugin/blob/master/platforms/android/README.md

Have you been able to make this work with Intel XDK?

We will not be creating a dependency plugin. The main issue is probably that the Facebook SDK is a separate Android project which must be included in your own project. the Cordova CLI cannot currently add sub-projects, so you have to do it manually (See the Android README). The Cordova Team however are working on adding this functionality in Cordova 4.0 I believe.

arnesikstrom commented 10 years ago

I did not do any tests other than to create a depency plugin for this one but that failes with "R$xxxx" methods not included.

Are there any other trix we can use to get this plugin to work "out of the box" for cloud build systems that only does "cordova plugin add ..." and nothing else?

This is the best Facebook plugin but without it working in a production environment I can't use it.

aogilvie commented 10 years ago

@frostyelkarne I confess I have not used Intel XDK.. Android and iOS should be automated for any cloud system that uses cordova plugin add. If Intel XDK does not use cordova to install plugins then that would be a problem.

arnesikstrom commented 10 years ago

Intel XDK is based on Cordova and uses "cordova plugin add". The problem is that the build fails in "cordova build".

So the following exact command sequence must work: 1) cordova plugin add x.y.z 2) cordova build

Please see Intel XDK docs for more information: https://software.intel.com/en-us/html5/xdkdocs